xiaoxiang781216 commented on code in PR #15387:
URL: https://github.com/apache/nuttx/pull/15387#discussion_r1899438990
##########
drivers/timers/Make.defs:
##########
@@ -28,6 +28,12 @@ ifeq ($(CONFIG_WATCHDOG),y)
TMRVPATH = :timers
endif
+ifeq ($(CONFIG_WATCHDOG_TIMEOUT_NOTIFIER),y)
+ CSRCS += wdt_notifier.c
Review Comment:
```suggestion
CSRCS += watchdog_otifier.c
```
##########
include/nuttx/wdt_notifier.h:
##########
@@ -0,0 +1,97 @@
+/****************************************************************************
+ * include/nuttx/wdt_notifier.h
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __INCLUDE_NUTTX_WDT_NOTIFIER_H
+#define __INCLUDE_NUTTX_WDT_NOTIFIER_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/notifier.h>
+#include <nuttx/sched.h>
+
+#include <sys/types.h>
+
+#ifdef CONFIG_WATCHDOG_TIMEOUT_NOTIFIER
+
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
+
+enum wdt_type_e
+{
+ WDT_KEEPALIVE_BY_ONESHOT = 0,
+ WDT_KEEPALIVE_BY_TIMER = 1,
+ WDT_KEEPALIVE_BY_WDOG = 2,
+ WDT_KEEPALIVE_BY_WORKER = 3,
+ WDT_KEEPALIVE_BY_CAPTURE = 4,
+ WDT_KEEPALIVE_BY_IDLE = 5
+};
+
+/****************************************************************************
+ * Public Function
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: wdt_notifier_chain_register
+ *
+ * Description:
+ * Add notifier to the wdt notifier chain
+ *
+ * Input Parameters:
+ * nb - New entry in notifier chain
+ *
+ ****************************************************************************/
+
+void wdt_notifier_chain_register(FAR struct notifier_block *nb);
Review Comment:
should we move to timer/watchdog.h
##########
include/nuttx/wdt_notifier.h:
##########
@@ -0,0 +1,97 @@
+/****************************************************************************
+ * include/nuttx/wdt_notifier.h
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __INCLUDE_NUTTX_WDT_NOTIFIER_H
+#define __INCLUDE_NUTTX_WDT_NOTIFIER_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/notifier.h>
+#include <nuttx/sched.h>
+
+#include <sys/types.h>
+
+#ifdef CONFIG_WATCHDOG_TIMEOUT_NOTIFIER
+
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
+
+enum wdt_type_e
+{
+ WDT_KEEPALIVE_BY_ONESHOT = 0,
Review Comment:
change WDT_/wdt_ prefix to WATCHDOG_/watchdog_
##########
include/nuttx/wdt_notifier.h:
##########
@@ -0,0 +1,97 @@
+/****************************************************************************
+ * include/nuttx/wdt_notifier.h
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __INCLUDE_NUTTX_WDT_NOTIFIER_H
+#define __INCLUDE_NUTTX_WDT_NOTIFIER_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/notifier.h>
+#include <nuttx/sched.h>
+
+#include <sys/types.h>
+
+#ifdef CONFIG_WATCHDOG_TIMEOUT_NOTIFIER
+
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
+
+enum wdt_type_e
Review Comment:
change to macro and remove enum
##########
drivers/timers/wdt_notifier.c:
##########
@@ -0,0 +1,91 @@
+/****************************************************************************
+ * drivers/timers/wdt_notifier.c
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/arch.h>
+#include <nuttx/notifier.h>
+
+#include <sys/types.h>
+
+#include <nuttx/wdt_notifier.h>
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static ATOMIC_NOTIFIER_HEAD(g_wdt_notifier_list);
Review Comment:
merge into watchdog.c
##########
include/nuttx/wdt_notifier.h:
##########
@@ -0,0 +1,97 @@
+/****************************************************************************
+ * include/nuttx/wdt_notifier.h
Review Comment:
```suggestion
* include/nuttx/timer/watchdog_notifier.h
```
##########
include/nuttx/wdt_notifier.h:
##########
@@ -0,0 +1,97 @@
+/****************************************************************************
+ * include/nuttx/wdt_notifier.h
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __INCLUDE_NUTTX_WDT_NOTIFIER_H
+#define __INCLUDE_NUTTX_WDT_NOTIFIER_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/notifier.h>
+#include <nuttx/sched.h>
+
+#include <sys/types.h>
+
+#ifdef CONFIG_WATCHDOG_TIMEOUT_NOTIFIER
+
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
+
+enum wdt_type_e
+{
+ WDT_KEEPALIVE_BY_ONESHOT = 0,
+ WDT_KEEPALIVE_BY_TIMER = 1,
Review Comment:
where do you use this macro/enum
##########
drivers/timers/wdt_notifier.c:
##########
@@ -0,0 +1,91 @@
+/****************************************************************************
+ * drivers/timers/wdt_notifier.c
Review Comment:
```suggestion
* drivers/timers/watchdog_notifier.c
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
