nuttxpr commented on PR #15384: URL: https://github.com/apache/nuttx/pull/15384#issuecomment-2565104191
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears **incomplete** and does not fully meet the NuttX requirements. While it provides a title under the Summary section, it lacks crucial details about the change's necessity, functionality, and related issues. The Impact and Testing sections are essentially placeholders, asking for information rather than providing it. Here's a breakdown of what's missing: * **Summary:** Needs a thorough explanation of the *why*, *what*, and *how* of the change. References to related issues are also missing. Just stating "Unified memory management alignment length" is insufficient. What was the previous behavior? What problem does this solve? What is the new alignment length? * **Impact:** The placeholder text needs to be replaced with concrete information. *Every* bullet point should have a "YES" or "NO" followed by a description if applicable. Even if the answer is "NO," it should be explicitly stated. * **Testing:** This section requires specific details about the testing environment and the results. Simply requesting the information isn't enough. The user needs to fill in the build host, target details, and importantly, the *actual* testing logs from before and after the change. Without these logs, there's no evidence that the change works as intended. Therefore, before this PR can be considered, the author needs to substantially revise it by providing the missing details in all three sections (Summary, Impact, and Testing). Simply replacing placeholders with "NO" is not enough; a proper justification is needed for each item. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
