nuttxpr commented on PR #15355: URL: https://github.com/apache/nuttx/pull/15355#issuecomment-2563528013
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The provided information is insufficient to determine if the PRs meet the NuttX requirements. While the PR links are provided, there's no information about the changes themselves. Listing the PRs doesn't replace the need to describe the impact of *each* PR. Here's why it's insufficient and what's needed: * **Summary:** Just providing links is not a summary. For each PR, you need to briefly explain: * The reason for the change (bug fix, feature, etc.). * What part of the code is affected. * How the change works. * Related issue references. * **Impact:** Stating "Release" doesn't explain the impact. For *each* PR, address the following: * Does it add or change features? If so, how will users be affected? * Does it change the build process? * Does it affect any specific hardware? * Does it require documentation updates? Have those updates been made? * Are there security implications? * Are there compatibility concerns? * **Testing:** "CI" is not enough. While CI is important, it should not be the only testing. For *each* PR, you need to provide: * Specific build hosts used for testing (OS, CPU, compiler). * Specific target hardware/simulators used. * Example logs *before* and *after* the change to demonstrate the fix or new functionality. CI logs can be part of this, but specific examples are crucial. Especially for bug fixes, showing the before/after state is essential. **In short, you need to provide the required information for *each* PR individually.** You cannot simply list links and assume the reviewer will go through each one and extract the necessary details. The purpose of the PR template is to provide concise yet comprehensive information about the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
