Re: [PR] arch/x86_64:g_current_regs is only used to determine if we are in irq, [nuttx]

[via GitHub]

xiaoxiang781216 commented on code in PR #15325:
URL: https://github.com/apache/nuttx/pull/15325#discussion_r1898005442


##########
arch/x86_64/src/intel64/intel64_smpcall.c:
##########
@@ -60,13 +60,11 @@
 
 int x86_64_smp_call_handler(int irq, void *c, void *arg)
 {
-  struct tcb_s *tcb;
   int cpu = this_cpu();
 
-  tcb = current_task(cpu);
+  current_task(cpu);

Review Comment:
   why add this



##########
arch/x86_64/src/intel64/intel64_smpcall.c:
##########
@@ -60,13 +60,11 @@
 
 int x86_64_smp_call_handler(int irq, void *c, void *arg)
 {
-  struct tcb_s *tcb;
   int cpu = this_cpu();
 
-  tcb = current_task(cpu);
+  current_task(cpu);
   nxsched_smp_call_handler(irq, c, arg);
-  tcb = current_task(cpu);
-  x86_64_restorestate(tcb->xcp.regs);
+  current_task(cpu);

Review Comment:
   ditto



##########
arch/x86_64/src/intel64/intel64_smpcall.c:
##########
@@ -93,12 +91,10 @@ int x86_64_smp_call_handler(int irq, void *c, void *arg)
 
 int x86_64_smp_sched_handler(int irq, void *c, void *arg)
 {
-  struct tcb_s *tcb;
   int cpu = this_cpu();
 
   nxsched_process_delivered(cpu);
-  tcb = current_task(cpu);
-  x86_64_restorestate(tcb->xcp.regs);
+  current_task(cpu);

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org