nuttxpr commented on PR #2916:
URL: https://github.com/apache/nuttx-apps/pull/2916#issuecomment-2562372735

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   ## Does this PR meet the NuttX Requirements? Please be concise
   
   No.  While it provides a summary, it lacks crucial details.
   
   **Missing Information:**
   
   * **Summary:**  Lacks specifics. *Why* is the current location unreasonable? 
 What part of the code is changed (directory structure only?  Makefiles?  Build 
system logic?) *How* does the merge work (simple move, scripts, etc.)? Are 
there related issues?
   * **Impact:**  Completely empty. This section needs to address *all* listed 
impact areas. Moving tests can have wide-ranging consequences, especially on 
build systems and user workflows.  At a minimum, expect build impact (Makefile 
changes) and user impact (locating tests).  Documentation almost certainly 
needs updating.
   * **Testing:** Empty.  Must provide build host and target details.  "Testing 
logs" should show the tests running *before* and *after* the change to 
demonstrate the change doesn't break anything and achieves the desired outcome. 
 Just saying "it works" is insufficient.  Show *how* you proved it works.
   
   
   **Example of an improved Summary:**
   
   The current location of test cases in `testsuites` makes it difficult to 
discover and run tests related to specific modules. This PR moves all tests 
under the `testing` directory, organizing them by module.  This change 
simplifies test discovery and execution and streamlines the testing process.  
This addresses the lack of organized testing highlighted in [NuttX Issue 
#XYZ](link-to-issue).  The change involves modifying the directory structure, 
updating Makefiles to reflect the new locations, and updating the CI scripts to 
run the relocated tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to