Zhangshoukui commented on PR #15326: URL: https://github.com/apache/nuttx/pull/15326#issuecomment-2561680666
> @Zhangshoukui I think we need to simplify the LINELEN / LINEMAX instead of creating a new one, currently there are many configs to that: > > CONFIG_SYSTEM_CLE_CMD_HISTORY_LINELEN CONFIG_SYSTEM_CLE_CMD_HISTORY_LEN CONFIG_NSH_LINELEN CONFIG_PROCFS_LINELEN CONFIG_HELP_LINELEN > > Having a LINELEN for each application could be more flexible, but it is also a lot a code duplication. It should be nice to have a single LINE_MAX to be the standard LINELEN Yes, the next step is to optimize and remove the above configuration to use LINE_MAX. remove this: config SYSTEM_CLE_CMD_HISTORY_LEN config SYSTEM_CLE_CMD_HISTORY_LINELEN CONFIG_NSH_LINELEN HELP_LINELEN PROCFS_LINELEN -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
