nuttxpr commented on PR #2899: URL: https://github.com/apache/nuttx-apps/pull/2899#issuecomment-2550489733
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not meet the NuttX requirements. While it attempts to follow the structure, it lacks crucial details. Here's why: * **Summary:** While it states the *why*, it's vague. What tools? What kind of SPDX identifiers? It completely omits *what* is changing, *how* the change works, and any related issue references. Example: "This change adds SPDX license identifiers to the source files within the core OS directory (e.g., `sched/`, `drivers/`). This will allow tools like [tool name] to generate a compliant SBOM. This addresses issue #[issue number]." * **Impact:** Simply stating "SBOM" isn't helpful. You need to address *all* impact points with "YES/NO" and descriptions where necessary. For example, "Impact on documentation: YES - The README will be updated to explain how to generate an SBOM." Even if the answer is "NO", state it explicitly. * **Testing:** "CI" isn't sufficient. List the specific build hosts and targets tested. Provide *actual* log snippets demonstrating the change's effect, not just "your testing logs here". Show the absence of SPDX identifiers before and their presence after the change. Example: * Build Host(s): Linux (Ubuntu 22.04), x86_64, GCC 11.2 * Target(s): qemu-sim:default Testing logs before change (excerpt from `sched/sched.c`): ```c /* No SPDX identifier present */ ``` Testing logs after change (excerpt from `sched/sched.c`): ```c // SPDX-License-Identifier: Apache-2.0 ``` In short, the PR description needs to be significantly more detailed and explicit to meet the NuttX requirements. It should provide specific information about the changes, their impact, and clear evidence of testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
