hartmannathan commented on PR #15188: URL: https://github.com/apache/nuttx/pull/15188#issuecomment-2546158623
> > > @linguini1 please squash into one patch > > > > > > I was suggested to keep a few logical commits in case it helps others; is this still the case? > > > > @linguini1 @xiaoxiang781216 I suggested him to reduce to few numbers of commits that preserve the logic process to adding this port, to be used as future reference. Nathan also agreed on that. Yes that's correct. I replied to xiaoxiang781216 before I noticed that the 170+ commits were already squashed to 4. I think it is OK to keep it as-is. Only the defconfig issue needs to be updated and then I think it will be ready for merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
