nuttxpr commented on PR #15127: URL: https://github.com/apache/nuttx/pull/15127#issuecomment-2533448997
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a title and sign-off, it lacks crucial information. Here's a breakdown of the missing information: * **Summary:** "esp/mcpwm: fix unpaired spin lock" is a good start for a title, but the summary needs to explain *why* the spinlock was unpaired (what bug did it cause?), *what* part of the mcpwm driver is affected, and *how* the fix addresses the issue. * **Impact:** "N/A" is almost certainly incorrect. Even a bug fix has *some* impact. At minimum, it fixes a bug which impacts functionality (presumably). This section needs to be thoughtfully filled out. Consider impact on: * Existing users (did the bug affect them?) * Hardware (is this specific to a particular ESP chip?) * Stability (did the unpaired lock cause crashes?) * **Testing:** "ci-check" is insufficient. While CI is important, the PR needs to demonstrate *local* testing and provide *specific* logs showing the problem before the change and the corrected behavior after the change. Generic statements like "ci-check" don't offer any evidence that the change actually works. Include the host and target details requested. In short, the PR needs to provide more context and evidence of testing to be considered complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
