nuttxpr commented on PR #15115: URL: https://github.com/apache/nuttx/pull/15115#issuecomment-2531455386
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a reason for the change, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** * Missing: "What functional part of the code is being changed?" (e.g., "The scheduler," "Interrupt handling subsystem," specific drivers, etc.) * Missing: "How does the change exactly work?" (e.g., "All instances of `spin_lock_irqsave(NULL)` are replaced with calls to `up_irq_save()`," or a more detailed explanation if the solution is more complex.) * Missing: Related issue references (if any). * **Impact:** "RELEASE" is insufficient. While it implies a potentially significant impact, it doesn't explain *what* the impact is. Each "Impact" sub-item needs a proper "YES" or "NO" and a description if "YES." For example: * Impact on user: Likely YES. If this changes interrupt behavior, user code that relies on specific interrupt timings might break. This needs to be explained. * Impact on build: Possibly YES. If changes are made to core kernel files, rebuilds might be required. * Impact on hardware: Potentially YES, depending on which parts of the code are changed. Specific architectures, boards, or drivers affected should be listed. * And so on for all other impact categories. * **Testing:** "CI" is insufficient. While Continuous Integration is important, the PR needs to show *specific* testing results. * Missing: Build Host details (OS, CPU, compiler). * Missing: Target details (architecture, board, configuration). * Missing: Actual "before" and "after" testing logs demonstrating the change in behavior and that the issue is fixed. Just stating "CI" doesn't provide this evidence. In short, the PR needs to be much more descriptive and provide concrete details for each required section. The current description offers very little information for reviewers to assess the change properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
