nuttxpr commented on PR #15113: URL: https://github.com/apache/nuttx/pull/15113#issuecomment-2531461214
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details. Here's what's missing: * **Summary:** While it states *what* was changed (removed extra spaces), it doesn't explain *why*. Was this for code style consistency? Did the extra spaces cause a problem? Which files were affected? This section needs more context. It should also include any related issue numbers. * **Impact:** Simply stating "RELEASE" is insufficient. Each impact category (user, build, hardware, documentation, security, compatibility) needs a "YES" or "NO" answer. If "YES," a description is required. Even if the answer is "NO" for all of them, it should be explicitly stated. For example: * Impact on user: NO * Impact on build: NO * ...and so on. * **Testing:** "CI" is not enough. The PR needs to specify the *local* testing performed *before* submitting to CI. This includes: * Build Host details (OS, CPU, compiler) * Target details (architecture, board, configuration) * Actual testing logs *before* the change * Actual testing logs *after* the change In short, the PR needs to be much more descriptive and provide specific details for each section of the requirements. Just stating keywords like "RELEASE" and "CI" doesn't offer enough information for proper review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
