nuttxpr commented on PR #15114: URL: https://github.com/apache/nuttx/pull/15114#issuecomment-2531458344
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a reason for the change, it lacks crucial details. Here's what's missing: * **Summary:** It needs more specifics. *What* functional part of the code uses `spin_lock_irqsave(NULL)`? *How* is it being removed (replaced with what)? What are the exact code changes? Issue/PR references are missing. * **Impact:** Marking "RELEASE" isn't sufficient. Each impact category (user, build, hardware, documentation, security, compatibility) needs a YES/NO answer and a description if YES. Just saying "RELEASE" doesn't tell us anything concrete about the impact. Even if the answer is NO for all, it needs to be explicitly stated. * **Testing:** "CI" isn't enough. What specific build hosts and targets were tested locally? "Testing logs before change" and "Testing logs after change" sections are empty. Actual logs are required to demonstrate the change works as intended. Relying solely on CI is insufficient for demonstrating local verification. The PR needs to be significantly more detailed to meet the requirements. It needs to show *what* was changed, *how* it was changed, *what the impact is*, and provide *evidence that it was tested*. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
