nuttxpr commented on PR #15111: URL: https://github.com/apache/nuttx/pull/15111#issuecomment-2531354064
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a reason for the change, it lacks crucial details. **Missing Information:** * **Summary:** The summary is incomplete. It states the *why* but not the *what* or *how*. Which functional parts of the code are affected? How are instances of `spin_lock_irqsave(NULL)` being removed? What is the replacement? * **Impact:** Marking "RELEASE" is insufficient. Each impact category (user, build, hardware, documentation, security, compatibility) requires a "YES" or "NO" answer. If "YES," a description of the impact is mandatory. The implications of removing `spin_lock_irqsave(NULL)` are not discussed. This function likely relates to interrupt handling, so there could be subtle impacts on various subsystems. * **Testing:** "CI" is not enough. While Continuous Integration is important, the PR needs to demonstrate *specific* testing performed locally *before* and *after* the change. The provided code blocks for testing logs are empty. What platforms were tested? What tests were run? What were the results? Specific build host and target details are missing. **In short, the PR needs to be much more descriptive and provide concrete evidence of testing and impact analysis.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
