nuttxpr commented on PR #15102: URL: https://github.com/apache/nuttx/pull/15102#issuecomment-2530122183
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not appear to meet the NuttX requirements based on the provided information. The summary is far too vague. It needs to clearly state *what* is being changed and *why*. "since the basepri is always used without any configuration" doesn't tell us anything about the actual change. The impact section is also insufficient. It references a previous PR but doesn't explain the impact of *this* PR. All the "NO/YES" questions should be answered explicitly with explanations where necessary. Finally, "ci" for testing is not acceptable. The requirements ask for specific build host and target information, as well as before/after testing logs. Simply saying "ci" doesn't demonstrate that the changes have been adequately tested. The reviewer needs to see the evidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
