nuttxpr commented on PR #15045: URL: https://github.com/apache/nuttx/pull/15045#issuecomment-2517120455
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears **incomplete** and does **not** fully meet the NuttX requirements. While it provides a summary of the change, it lacks crucial information in the Impact and Testing sections. Here's a breakdown: * **Summary:** Adequate, though a more detailed explanation of *how* the virtio queue address was incorrectly set and *how* the fix corrects it would be beneficial. * **Impact:** Completely empty. This section needs to be filled out. At minimum, consider: * **Impact on hardware:** This fix likely affects virtio devices, so specify which architectures and boards are impacted. * **Impact on compatibility:** Does this fix introduce any backward compatibility issues with older virtio drivers or configurations? * **Impact on security:** Incorrect memory addressing could have security implications. Even if the answer is NO, explicitly state it and provide a brief justification. * **Testing:** Empty. This is a critical deficiency. Provide details on: * **Build Host:** OS, CPU architecture, compiler version. * **Target:** Architecture (e.g., QEMU, a specific RISC-V board), board configuration. * **Logs:** Include logs demonstrating the issue *before* the change and showing the correct behavior *after* the change. These logs should ideally show the virtio queue addresses. **To make this PR acceptable, the Impact and Testing sections must be completed with specific details.** Simply stating "NO" for all impact categories is insufficient; a brief explanation is necessary, especially if the impact is indeed minimal. Without testing logs and a description of the test setup, reviewers cannot effectively evaluate the correctness of the proposed fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
