nuttxpr commented on PR #15033: URL: https://github.com/apache/nuttx/pull/15033#issuecomment-2514231125
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the change, it lacks crucial details. Here's what's missing: * **Summary:** While the "what" is addressed (replacing `spin_lock_irqsave(NULL)`), the "why" and "how" are insufficient. Why is removing this specific call important? What alternative locking mechanism is used? How does the new lock impact the code's functionality? What are the benefits of this change (e.g., improved performance, reduced interrupt latency)? * **Impact:** Simply stating "rp23xx" isn't enough. Be explicit. Does this change impact any specific boards or configurations? Are there any user-facing changes? All the other impact categories (build, hardware, documentation, security, compatibility) are simply omitted. They should be explicitly stated as NO or YES with explanations if YES. * **Testing:** "ci" is not sufficient testing information. While CI testing is important, local testing is also required and should be documented. Provide details about the local setup used for testing (OS, compiler, target architecture and board). Crucially, the "Testing logs before change" and "Testing logs after change" sections are empty. These are essential for demonstrating the effect of the change. What tests were run? What were the results before and after the change? How do these results confirm the fix? To make this PR acceptable, you need to provide the missing information in each section. Be specific and provide concrete details to demonstrate that the change is well-motivated, correctly implemented, and thoroughly tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
