nuttxpr commented on PR #14996: URL: https://github.com/apache/nuttx/pull/14996#issuecomment-2507858407
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not adequately meet the NuttX requirements. While it touches on some points, it lacks crucial details. Here's a breakdown: * **Summary:** While it states the "why," it's vague about the "what" and "how." Which files are changed? How are SPDX identifiers being added? What tools are being targeted? The summary needs more concrete information. Issue/PR references are missing. * **Impact:** Simply stating "SBOM" is insufficient. It needs to address *all* the listed impact categories with specific "YES/NO" answers and explanations where applicable. For example: * Is new feature added? YES (SBOM generation capability) * Impact on user? Potentially YES (if SBOM generation becomes part of the build process, users may need to configure it). More details are required. * Impact on build? Possibly YES. Needs explanation. * ...and so on for all categories. * **Testing:** "CI" is not acceptable. The PR description *must* include: * Specific build host details (OS, CPU architecture, compiler version) * Specific target details (architecture, board, configuration) * Relevant log snippets demonstrating the functionality before and after the change, not just a general statement about CI. If the change is specifically to facilitate SBOM generation, show how the SBOM output differs before and after the change. In short, the PR description needs to be significantly expanded to be considered acceptable according to the NuttX requirements. It needs to be more specific and address all the listed points in detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
