yamt commented on code in PR #14923:
URL: https://github.com/apache/nuttx/pull/14923#discussion_r1856432631


##########
drivers/syslog/Kconfig:
##########
@@ -407,5 +407,25 @@ config SYSLOG_REGISTER
        ---help---
                This option will support register the syslog channel 
dynamically.
 
+config SYSLOG_STDOUT

Review Comment:
   honestly speaking, i don't think it makes much sense to have a kconfig for 
this specific exotic configuration.
   



##########
drivers/syslog/Kconfig:
##########
@@ -407,5 +407,25 @@ config SYSLOG_REGISTER
        ---help---
                This option will support register the syslog channel 
dynamically.
 
+config SYSLOG_STDOUT
+       bool "Redirect standard output stream of printf() and vprintf() to 
syslog"
+       default n
+       ---help---
+               Redirect standard output stream of printf(), vprintf(), puts(), 
putchar() to syslog,

Review Comment:
   standard output is not a per-function entity.
   "standard output stream of printf()" doesn't make sense.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to