YuuichiNakamura commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-nuttx/pull/1377#discussion_r452558599
##########
File path: drivers/syslog/note_driver.c
##########
@@ -41,34 +41,62 @@
#include <sys/types.h>
#include <sched.h>
+#include <fcntl.h>
#include <assert.h>
#include <errno.h>
+#include <string.h>
#include <nuttx/sched_note.h>
+#include <nuttx/sched_note_trace.h>
Review comment:
I see. I got it.
##########
File path: include/nuttx/sched_note.h
##########
@@ -348,12 +379,13 @@ void sched_note_irqhandler(int irq, FAR void *handler,
bool enter);
# define sched_note_irqhandler(i,h,e)
#endif
+void sched_note_message(FAR const char *fmt, ...);
Review comment:
I got. I'll remove sched_note_message features to make another PR for it.
Also ok for the changes of syscall arg/result and irq handler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
