nuttxpr commented on PR #14900: URL: https://github.com/apache/nuttx/pull/14900#issuecomment-2492954405
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not meet the NuttX requirements. The summary is insufficient and lacks critical information. The impact and testing sections are essentially empty placeholders. Specifically: * **Summary:** The summary focuses on an apology for a previous commit, which is irrelevant. It mentions a platform change (x86-64 vs. x86) but fails to describe the actual change being made, its purpose, and the affected functional part of the code. It should also reference any related issues. * **Impact:** The placeholder text needs to be replaced with actual analysis of the impact on users, build process, hardware, documentation, security, and compatibility. Simply stating "NO" or "YES" is insufficient; a description is required for all "YES" answers, and often helpful for "NO" answers to explain why there is no impact. * **Testing:** The placeholder text needs to be replaced with specific details on the testing performed, including the host and target environments, and, crucially, the actual testing logs from before and after the change. Simply claiming the changes work is not enough; evidence is needed. This PR needs significant revision before it can be considered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
