nuttxpr commented on PR #2863: URL: https://github.com/apache/nuttx-apps/pull/2863#issuecomment-2492822700
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to be **missing crucial information** to meet the NuttX requirements. While it provides a skeletal structure, it lacks the necessary details in almost every section. **Missing Information:** * **Summary:** The summary only mentions `MAX_SIGNO` being a valid signal number. This doesn't explain *why* this change is needed, *what* code is changed, or *how* the change works. Is this a bug fix? A new feature? What problem does it solve? * **Impact:** All impact sections are empty. This makes it impossible to assess the ramifications of the change. Even if the impact is minimal for some categories, explicitly stating "NO" with a brief justification is better than leaving it blank. * **Testing:** While a target is listed (`esp32s3-devkit:smp`), the critical "before" and "after" testing logs are empty. Without these logs, there's no evidence that the change works as intended or that the problem being addressed is actually fixed. The build host details are also missing. **To make this PR compliant, the author needs to provide:** * A complete summary explaining the context, the change, and its purpose. * Fill out *all* impact sections, even if the answer is "NO." Justify "NO" answers briefly. If the answer is "YES," provide a detailed explanation. * Include actual testing logs demonstrating the behavior before and after the change. Specify the build host details (OS, CPU, compiler). Without this information, reviewers cannot effectively evaluate the PR. It's likely to be rejected in its current state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
