XuNeo commented on code in PR #14854: URL: https://github.com/apache/nuttx/pull/14854#discussion_r1853152697
########## tools/gdb/macros.py: ########## @@ -0,0 +1,214 @@ +############################################################################ +# tools/gdb/macros.py +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +# NOTE: GDB stores macro information based on the current stack frame's scope, +# including the source file and line number. Therefore, there may be missing +# macro definitions when you are at different stack frames. +# +# To resolve this issue, we need to retrieve all macro information from the ELF file +# then parse and evaluate it by ourselves. +# +# There might be two ways to achieve this, one is to leverage the C preprocessor +# to directly preprocess all the macros instereted into python constants Review Comment: Hi, these typos are fixed in PR GDB Plugin Upgrade part1. I have rebased and now they should be fixed. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
