Gary-Hobson commented on code in PR #14838: URL: https://github.com/apache/nuttx/pull/14838#discussion_r1848622676
########## libs/libbuiltin/libgcc/Make.defs: ########## @@ -19,10 +19,12 @@ ############################################################################ ifeq ($(CONFIG_PROFILE_MINI),y) - CSRCS += profile.c +endif + +ifeq ($(CONFIG_COVERAGE_MINI)$(CONFIG_ARCH_TOOLCHAIN_GCC),yy) +CSRCS += gcov.c Review Comment: This cannot have the same name as coverage.c in compiler-rt. When compiling using makefile, it will search for coverage.c in the compiler-rt directory, causing it to not find the correct symbol when linking. ########## libs/libbuiltin/libgcc/CMakeLists.txt: ########## @@ -22,3 +22,8 @@ if(CONFIG_PROFILE_MINI) nuttx_add_system_library(libgprof) Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
