nuttxpr commented on PR #14759: URL: https://github.com/apache/nuttx/pull/14759#issuecomment-2472683222
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it mentions keeping `can_bytes2dlc` and `can_dlc2bytes`, it lacks crucial information. Specifically, it's missing: * **Clear Explanation of the Change:** The summary doesn't explain *why* only these two functions are being kept. What is being removed? What problem does this solve? What's the motivation? * **Detailed Impact Assessment:** The impact section is completely empty. This needs to be filled out describing the effects on users, build, hardware, documentation, security, and compatibility. Removing code almost certainly has *some* impact. * **Testing Information:** The testing section is also empty. What platforms were used for testing? What were the results? "Works as intended" is not sufficient; concrete examples of tests and their outcomes are needed. The logs sections are empty. **To make this PR acceptable, the author needs to:** 1. **Explain the "why" behind the change.** Provide a clear and concise explanation of the reason for removing the other functions. What problem did they cause? What are the benefits of removing them? 2. **Complete the Impact Assessment.** Consider all aspects listed in the template (users, build, hardware, docs, security, compatibility) and explain how this change affects each. Even if the answer is "NO", it should be stated explicitly. 3. **Provide detailed testing information.** List the build host(s) and target(s) used for verification. Include the actual testing logs from before and after the change to demonstrate the effect of the modification. Only then will the PR meet the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
