liamHowatt opened a new pull request, #14701:
URL: https://github.com/apache/nuttx/pull/14701

   cc @XuNeo @FASTSHIFT
   
   ## Summary
   
   Make the esp32s3 LCD FB device support double buffering. Leverage the FB 
`pandisplay` callback for users to achieve [double buffering in applications 
such as 
LVGL](https://github.com/lvgl/lvgl/blob/f89ac3677e6666449835d765d182f5515770c984/src/drivers/nuttx/lv_nuttx_fbdev.c#L275-L288).
 Use DMA interrupt to facilitate vsync.
   
   ## Impact
   
   I would like feedback on how this change should be managed. I made it so 
that the feature will be active if there is 1 LCD layer. The impact is that 
double the memory will be allocated compared to before this change, which could 
cause users to have insufficient memory after upgrading. Should it be a Kconfig 
option?
   
   ## Testing
   
   Mainboard: ESP32-S3-LCD-EV-Board-MB_V1.5
   LCD Subboard: ESP32-S3-LCD-EV-Board-SUB2_V1.5
   
   config: `esp32s3-lcd-ev:lvgl`
   
   For the specific board model:
   ```
   kconfig-tweak --set-val CONFIG_ESP32S3_I2C0_SCLPIN 48
   kconfig-tweak --set-val CONFIG_ESP32S3_I2C0_SDAPIN 47
   kconfig-tweak --set-val CONFIG_ESP32S3_LCD_DATA6_PIN 8
   kconfig-tweak --set-val CONFIG_ESP32S3_LCD_DATA7_PIN 18
   yes '' | make oldconfig
   ```
   
   LVGL will [detect the effect of the 
changes](https://github.com/lvgl/lvgl/blob/f89ac3677e6666449835d765d182f5515770c984/src/drivers/nuttx/lv_nuttx_fbdev.c#L145-L154)
 in the PR and double buffering will take effect without any other changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to