jlaitine commented on code in PR #14546:
URL: https://github.com/apache/nuttx/pull/14546#discussion_r1820999175


##########
arch/arm64/src/imx9/Kconfig:
##########
@@ -82,8 +82,11 @@ menu "USDHC"
 
 config IMX9_USDHC
        bool
-       default n
        select ARCH_HAVE_SDIO_PREFLIGHT
+       select FAT_DMAMEMORY
+       select FAT_FORCE_INDIRECT

Review Comment:
   Thanks for the comments!
   
   Now I see that this PR doesn't really make sense. Those flags are only 
needed if FAT is used on eMMC/SD cards. I don't think that there is a nice 
automatic way to do that. What Xiao suggested is closest, but not quite 
accurate either (there could be FAT on some other device, in which case these 
flags wouldn't be needed).
   
   I will just add the configs into my own boards defconfigs, and cancel this 
PR.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to