nuttxpr commented on PR #14545: URL: https://github.com/apache/nuttx/pull/14545#issuecomment-2443809235
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is adequate, but the remaining sections lack some details. Here's a breakdown and suggestions for improvement: **Summary:** * **Good:** Clearly states the "why" (fixing issues found during testing) and the "what" (cleaning up driver code, fixing hardware flow control, enabling RX/TX FIFOs in interrupt mode). * **Could be improved:** Briefly mention the specific issues found during testing for better context. **Impact:** * **Needs improvement:** * While it mentions impact on imx9 lpuart, be more specific about the affected features or functionalities. * Address all the bullet points mentioned in the requirements. Even if the answer is "NO," explicitly state it. * For example: * Is new feature added? YES (RX/TX FIFO in interrupt mode) * Is existing feature changed? YES (Hardware flow control fixed) * Impact on user: YES (Users can now utilize hardware flow control and FIFO interrupt mode for LPUART) * Impact on build: NO * ... and so on for all the remaining bullet points. **Testing:** * **Needs significant improvement:** * **Insufficient detail on build host:** Specify the OS, CPU architecture, and compiler version used for testing. * **Unclear target details:** "custom imx9 hardware" is too vague. Provide the specific board name or model and the configurations used. * **Missing logs:** The "Testing logs before change" and "Testing logs after change" sections are empty. Include relevant log snippets demonstrating the issues before the fix and the correct behavior after the fix. **To make this PR meet the NuttX requirements, you should:** 1. **Expand the "Impact" section** to address all bullet points with specific details, even if the answer is "NO." 2. **Provide comprehensive testing information:** * Specify your build host environment (OS, CPU, compiler). * Clearly identify your target hardware (board name/model, configuration). * Include relevant log snippets demonstrating the problem before and the solution after your changes. By providing this additional information, you make it much easier for reviewers to understand, evaluate, and ultimately merge your PR into the NuttX codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
