nuttxpr commented on PR #2797: URL: https://github.com/apache/nuttx-apps/pull/2797#issuecomment-2443046056
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not fully meet the NuttX requirements.** **Missing Information:** * **Summary:** * A more detailed explanation of *why* these changes are necessary is needed. Are these bug fixes? Feature enhancements? * What is the exact functionality of `netlib_getarptab.c` and `nsh_netcmds.c`? * Provide specific examples of how the display is improved and how the `ENETUNREACH` error is handled. * Include links to related NuttX Issues or Pull Requests if applicable. * **Impact:** * Address *all* impact points. Even if there is no impact, state "NO" explicitly for each point. * For example: * Impact on user: NO * Impact on build: NO * ... * **Testing:** * **Build Host(s):** Specify the operating system, CPU architecture, and compiler used for building. * **Before/After Logs:** The provided logs are placeholders. Include actual testing logs demonstrating the issue before the change and the improvement after the change. **Recommendations:** 1. **Expand the Summary:** Provide a clear and concise explanation of the changes, their purpose, and their effects. 2. **Address all Impact Points:** Even if there's no impact, state it clearly for each item. 3. **Provide Detailed Testing Information:** Include specific details about your build environment and provide real testing logs showcasing the changes in action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
