nuttxpr commented on PR #2790: URL: https://github.com/apache/nuttx-apps/pull/2790#issuecomment-2440450824
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, the PR does not fully meet the NuttX requirements.** Here's why and how to improve: * **Summary:** * **Missing:** You need to be more specific about *why* these changes are necessary. * Is this fixing a bug? * Are you improving performance? * What was the problem with the pm case in SMP mode? * **Missing:** You need to describe *what* functional parts of the code are being changed. * Which drivers are being updated in `drivertest`? * What specific changes were made to the `pm` case? * **Impact:** * **Incomplete:** You only mention the impact on the `pm` case. You need to address *all* impact categories even if the answer is "NO" (and provide a brief justification). For example: * **Impact on build:** Even if the build process doesn't change, state that explicitly (e.g., "NO - No changes to the build system or dependencies"). * **Impact on hardware:** Be specific about which architectures and boards are affected. * **Testing:** * **Insufficient:** * **Build Host(s):** Specify the operating system, CPU architecture, and compiler version used for testing. * **Target(s):** Be specific about the target architecture (e.g., "qemu-armv8a" is a good start, but include the specific board configuration). * **Missing Logs:** You need to provide actual testing logs *before* and *after* your changes. This helps reviewers understand the problem you're solving and verify that your changes have the intended effect. **Recommendations:** 1. **Expand the Summary:** Provide more context and details about the changes. 2. **Complete the Impact Section:** Address all categories, even if the answer is "NO." 3. **Provide Detailed Testing Information:** Include specific build host and target details, along with actual testing logs demonstrating the problem and the solution. By providing more information, you'll make it much easier for maintainers to review and merge your PR quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
