nuttxpr commented on PR #14509: URL: https://github.com/apache/nuttx/pull/14509#issuecomment-2437437683
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not fully meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of *why* the change from `random pool` to `getrandom` is necessary. What problem does it solve? * Needs more detail on the functional code changes. "move the implementation from crypto to libc" is vague. Be specific about functions or modules impacted. * **Impact:** * While "Make arc4random_buf always available" is a result, explain *how* this impacts users or the system. Is there a performance difference? Why is this availability important? * The impact sections are largely incomplete. Address *all* points (build, hardware, documentation, security, compatibility) with either "NO" or a "YES" + explanation. * **Testing:** * "ci" is insufficient. Provide actual build host and target details as requested. * "Testing logs before/after" are missing entirely. Show evidence of the problem the PR fixes AND that it now works as intended. **Recommendations:** 1. **Expand the Summary:** Clearly articulate the problem and solution. Provide specific code-level details. 2. **Complete Impact Assessment:** Address all impact points. Even if the answer is "NO", state it explicitly. 3. **Provide Detailed Testing Information:** Include build host/target specifics and relevant logs demonstrating the change's effect. **By providing this missing information, your PR will be much stronger and easier for reviewers to understand and approve.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
