nuttxpr commented on PR #14465: URL: https://github.com/apache/nuttx/pull/14465#issuecomment-2430640628
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is somewhat informative, but the rest of the information is insufficient to determine if it meets NuttX requirements. Here's a breakdown: **What's Good:** * **Summary:** Clearly states the technical changes made. The performance improvement mentioned is a good addition. * **Testing:** Mentions specific boards used for testing. **What's Missing:** * **Summary:** * **Why?** No explanation of the problem the PR solves. Why were the original semaphore operations slow? Why is atomicity important in this context? * **Issue reference:** Is there a related NuttX issue? * **Impact:** * **User Impact:** While the summary mentions semaphore changes, it doesn't explain if users need to adapt their code. Will existing semaphore usage still work correctly? * **Other Impacts:** The PR lacks details about potential impacts on build systems, hardware, documentation, security, and compatibility. * **Testing:** * **Incomplete Information:** The PR needs to specify the host operating system, CPU architecture, and compiler used for testing. * **Vague Descriptions:** "bes board with monkey test pass" and "sabre-6quad:smp with ostest pass" are too vague. Provide specific details about the tests performed and what "pass" means in each context. * **Missing Logs:** The PR should include actual testing logs from before and after the changes, as the template requests. **Conclusion:** The PR needs significant improvements to meet NuttX requirements. It needs to be more descriptive, particularly in the "Impact" section and provide specific evidence of testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
