nuttxpr commented on PR #14453: URL: https://github.com/apache/nuttx/pull/14453#issuecomment-2429271947
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does not meet the NuttX requirements. Here's why: * **Insufficient Summary:** The summary lacks critical information. * **Purpose:** Why are spaces being removed and tabs added to Kconfig files? Is this for code style consistency, to fix a bug, or another reason? * **Specifics:** Which Kconfig files are affected? The summary should clearly state the scope of the changes. * **Incomplete Impact Assessment:** Even seemingly minor changes can have unintended consequences. The PR needs to address: * **Build Impact:** Will this change how Kconfig files are parsed? Could it break builds on certain systems? * **Compatibility:** Could this impact existing configurations or scripts that rely on the previous formatting? * **Missing Testing Details:** * **No Environments:** The PR needs to specify the build hosts and target platforms where the changes were tested. * **No Logs:** "Testing logs before change" and "Testing logs after change" sections are empty. Provide concrete evidence that the changes work as expected and haven't introduced regressions. **Recommendations** 1. **Expand the Summary:** Clearly articulate the problem this PR solves or the improvement it introduces. Be specific about which files are modified. 2. **Thoroughly Analyze Impact:** Consider potential effects on the build system, compatibility, and user experience. 3. **Provide Detailed Testing Information:** * List all build hosts (OS, CPU, compiler) and target platforms (architecture, board, configuration). * Include relevant logs or output that demonstrate the functionality before and after your changes. By addressing these points, you'll make your PR easier to review and increase its chances of being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
