JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1807897094
##########
nshlib/nsh_parse.c:
##########
@@ -2466,7 +2487,7 @@ static int nsh_nice(FAR struct nsh_vtbl_s *vtbl, FAR char
**ppcmd,
#ifdef CONFIG_NSH_CMDPARMS
static int nsh_parse_cmdparm(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline,
- FAR const char *redirfile_out)
+ FAR const struct nsh_param_s *exec)
Review Comment:
done, but shadows warning occured, should we update as below? (as current
version does)
```
nsh_parse.c:792:26: warning: declaration of ‘param’ shadows a parameter
[-Wshadow]
792 | struct sched_param param;
| ^~~~~
nsh_parse.c:637:54: note: shadowed declaration is here
637 | FAR const struct nsh_param_s *param)
|
```
```diff
- struct sched_param param;
+ struct sched_param sched;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
