nuttxpr commented on PR #14387: URL: https://github.com/apache/nuttx/pull/14387#issuecomment-2420113011
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) While the provided PR information covers the essential elements of the NuttX requirements, it lacks the necessary details to determine if it fully meets them. Here's a breakdown of what's missing and how to improve the PR: **Summary:** * **What functional part of the code is being changed?** Specify the affected module(s) or component(s). For example, is this related to tracing, debugging, or a specific driver? * **How does the change exactly work (what will change and how)?** Provide a more technical explanation of the fixes. For example: * How was the non-existing variable `args.out` being used, and what is the correct approach now? * What was causing the dump trace to not write to the output file, and how is it resolved? * How was the `-o` flag being ignored, and how is it correctly handled now? **Impact:** * You need to fill out each impact category (even if the answer is "NO"). For example: * **Is new feature added? Is existing feature changed?** - This is a bug fix, so likely "Existing feature changed". * **Impact on user (will user need to adapt to change)?** - If the fix only corrects incorrect behavior without changing the interface or usage, then it's likely "NO". However, if the fix changes how the user interacts with the feature (e.g., the `-o` flag now behaves differently), then it would be "YES" with a description. * Do this for all remaining impact categories. **Testing:** * **Build Host(s):** Provide details about the operating system, CPU architecture, and compiler used for building. * **Target(s):** Specify the target architecture (e.g., sim, RISC-V, ARM) and the board configuration used for testing. * **Testing logs before and after change:** While you mention verification, it's essential to include relevant snippets from the testing logs. This helps reviewers understand the problem and verify the fix's effectiveness. **In summary, while the provided PR information is a good start, it needs more details to be considered complete according to the NuttX requirements. By providing specific information about the changes, their impact, and detailed testing logs, you'll make it easier for reviewers to understand and approve your PR.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
