yamt commented on code in PR #13498:
URL: https://github.com/apache/nuttx/pull/13498#discussion_r1804453886


##########
include/nuttx/fs/fs.h:
##########
@@ -227,6 +229,10 @@ struct file_operations
 
   CODE int     (*poll)(FAR struct file *filep, FAR struct pollfd *fds,
                        bool setup);
+  CODE ssize_t (*readv)(FAR struct file *filep, FAR const struct iovec *iov,

Review Comment:
   > > BTW, we can add pos to readv/writev to fix the race condition in 
readp/writep too.
   > 
   > i'm thinking to make readv/wirtev take something like bsd uio structure 
instead of taking iov/iovcnt directly so that it can be extended later. how do 
you think?
   > 
   > ```
   > struct uio {
   >   struct iovec *uio_iov;
   >   int iovcnt;
   > };
   > ```
   > 
   > cf. https://man.freebsd.org/cgi/man.cgi?query=uio&sektion=9&format=html
   
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to