nuttxpr commented on PR #2748:
URL: https://github.com/apache/nuttx-apps/pull/2748#issuecomment-2418436220

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   This PR appears **incomplete** based on the NuttX requirements. Here's why:
   
   * **Summary Lacks Detail:**  
       * **Why?**  The summary just states "nsh: support watch command." 
Explain the reason for this change. Is it a new feature request, a bug fix, or 
an improvement?
       * **What/How?** Provide more detail on the functionality of the `watch` 
command. What does it do? How will users interact with it?  
       * **Links:** Include links to any related NuttX issues or pull requests.
   
   * **Impact is Empty:**  You need to address each impact category:
       * **New/Changed Feature?**  Yes, it seems like a new feature. Describe 
it.
       * **User Impact?** Will users need to change anything in their existing 
scripts or usage?
       * **Build Impact?**  Does adding this command change anything about how 
NuttX is built?
       * **Hardware Impact?**  Are there specific hardware requirements for 
this command? 
       * **Documentation?** Does this PR include documentation updates for the 
`watch` command? If not, mention that it's needed.
       * **Security/Compatibility?**  Consider if this command has any security 
implications or affects compatibility.
   
   * **Testing is Insufficient:**
       * **Build Host Details:** Specify the operating system, CPU 
architecture, and compiler used for testing on your local setup. (e.g., "Linux, 
x86_64, GCC 12.2")
       * **Target Details:** Be more specific than "sim." Which simulator? 
Provide the architecture and board configuration. (e.g., "qemu-rv32, sim:nsh") 
       * **Testing Logs:**  You need to provide actual testing logs from before 
and after the change. These logs should demonstrate the issue you're fixing or 
the functionality of the new command.
   
   **In short:** You need to fill out the PR template with much more specific 
information for it to be considered complete. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to