nuttxpr commented on PR #2741: URL: https://github.com/apache/nuttx-apps/pull/2741#issuecomment-2416352488
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears **incomplete** and **does not meet** the NuttX requirements. Here's why: * **Summary:** * **Missing crucial information:** The summary only mentions a problem ("Casting '-1' to `size_t`..."). It needs to explain: * **Why is this a problem?** What issue does this casting cause? * **What is the solution?** How does the PR fix the problem? * **Where is the problem?** "cmd_cat" suggests the affected code, but the specific file/function needs clarification. * **Links to related issues:** If this fix relates to any existing NuttX issues, include their links. * **Impact:** * **Insufficient details:** Simply stating "cmd_cat" doesn't convey the impact. Consider these questions: * **Functionality:** Does the PR change how `cmd_cat` behaves for users? * **Compatibility:** Does it break any existing functionality or introduce backward compatibility issues? * **Testing:** * **Uninformative:** "CI" is too vague. Provide specifics: * **Build Hosts:** List the operating systems, compilers, and architectures used for testing. * **Target(s):** Specify the target architectures, boards, and configurations used. * **Missing Logs:** You **must** include testing logs from **before** and **after** the change. This proves that the issue existed and the PR successfully addresses it. **Recommendations:** 1. **Expand the Summary:** Clearly describe the problem, solution, and location of the change within the codebase. 2. **Detail the Impact:** Provide specific information on how the PR affects functionality, compatibility, build processes, documentation, etc. 3. **Improve Testing Information:** List all build hosts and target environments used. Include actual testing logs from before and after applying the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
