nuttxpr commented on PR #14361: URL: https://github.com/apache/nuttx/pull/14361#issuecomment-2415932693
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * Lacks a clear explanation of why the change is necessary. Is it a bug fix, an update to a dependency, or a new feature? * Doesn't specify the functional part of the code being modified (e.g., camera driver, sensor API). * Omits details on how the change works. What exactly is being adapted? How does the adaptation affect the code? * No issue references provided for context. * **Impact:** * **Impact on user:** Simply stating "Impact resolution of camera output in sim environment" is vague. Specify: * How does the resolution change (e.g., higher, lower, user-configurable)? * Will existing user applications break? * Are there new configuration options users need to be aware of? * **Impact on build, hardware, documentation, security, compatibility:** All marked "NO" without justification. This is unlikely for a change affecting camera output. Provide details if applicable; otherwise, explain why these areas are not impacted. * **Testing:** * **Build Host(s) and Target(s):** Provide specifics about the environments where you tested the changes. * **Testing logs:** "CI" is not sufficient. Include relevant snippets of logs showing the camera output behavior before and after the change. Demonstrate that the adaptation works as expected. **Recommendations:** 1. **Expand the Summary:** Provide a concise but informative description addressing the missing points mentioned above. 2. **Clarify Impact:** Be specific about the consequences of the change, particularly for users and potentially affected system components. 3. **Provide Detailed Testing Information:** List the build hosts and target environments, and include relevant log excerpts showing the impact of your changes on camera output. By addressing these points, you'll significantly improve the quality of your PR and make it easier for reviewers to understand and approve your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
