nuttxpr commented on PR #2740: URL: https://github.com/apache/nuttx-apps/pull/2740#issuecomment-2415873997
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This Pull Request is **missing critical information** and **does not meet** the NuttX requirements. **Here's why:** * **Summary is Insufficient:** * It only provides a vague title. * It needs to explain WHY the change is necessary, WHAT part of the coredump functionality is affected, and HOW the memory region initialization is modified. * **Impact is Incomplete:** * It only mentions "coredump" without specifying the impact. * Address ALL impact points (user impact, build impact, hardware impact, documentation, security, compatibility). Even if the answer is "NO", state it explicitly. * **Testing Lacks Detail and Evidence:** * It only shows a configuration command. * Provide: * **Build Host Details:** Your OS, CPU architecture, compiler, and versions. * **Target Details:** The specific architecture (simulator or real hardware), the board and its configuration. * **Logs:** Actual "before" and "after" logs demonstrating the change in functionality. This is essential to prove your changes work. **To meet the NuttX requirements, you need to significantly expand on all sections of your PR description.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
