nuttxpr commented on PR #2739: URL: https://github.com/apache/nuttx-apps/pull/2739#issuecomment-2415823533
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is good and informative. However, it needs slight improvements in the "Impact" and "Testing" sections to meet all NuttX requirements. **Impact:** While the impact may be minimal, simply stating "None" for all fields is not sufficient. You should elaborate on each point, even if it's to confirm there's no impact. For example: * **Is new feature added? Is existing feature changed?** Yes, a new timerjitter test case is added. * **Impact on user (will user need to adapt to change)?** NO. This is a new test case and does not affect existing user functionality. * **Impact on build (will build process change)?** NO. This adds a new test case and does not modify the build process. * **Impact on hardware (will arch(s) / board(s) / driver(s) change)?** NO. This is a software test case and does not impact hardware. * **Impact on documentation (is update required / provided)?** YES. Documentation should be updated to include information about the new timerjitter test case and its usage. * **Impact on security (any sort of implications)?** NO. This is a testing utility and does not introduce any security implications. * **Impact on compatibility (backward/forward/interoperability)?** NO. This is a new test case and does not impact compatibility. * **Anything else to consider?** N/A **Testing:** * **Be more specific about the testing environment.** Instead of just "QEMU/x86_64", specify the QEMU version and the guest operating system configuration. For NUC12, mention the specific board and NuttX configuration used. * **Provide snippets of the testing logs before and after the change.** While full logs might be excessive, including relevant snippets showcasing the test results before and after your changes is crucial. This helps reviewers understand the improvement your changes bring. By addressing these points and providing more specific information, your PR will better meet the NuttX requirements and make it easier for reviewers to understand and approve your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
