nuttxpr commented on PR #14355: URL: https://github.com/apache/nuttx/pull/14355#issuecomment-2415748675
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. **No, this PR does not meet the NuttX Requirements.** **Missing Information:** * **Summary:** * **What functional part of the code is being changed?** (e.g., Which file(s) are being modified?) * **How does the change exactly work?** (e.g., What is the existing license? How is the license being updated?) * **Impact:** * **Is new feature added? Is existing feature changed?** (This appears to be a bug fix or legal requirement, not a feature change). * The impact sections should clearly state "NO" or "YES" followed by a description if applicable. * **Testing:** * While testing might not be required for a license change, you should still confirm that the code compiles successfully after the license update. Provide details about the build environment and any relevant logs. **Recommendations:** 1. **Provide Specific Details:** Clearly describe the exact changes made to the `strptime` file, including the old and new licenses. 2. **Clarify Impact:** Explain why the MIT license is required. Is there a compilation error without it? Does this impact any existing functionality? 3. **Provide Build Confirmation:** Even if no functional testing is needed, confirm that the code compiles as expected after the license change. Specify the build environment used. By addressing these points, your PR will be more informative and aligned with the NuttX contribution guidelines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
