xuxin930 opened a new pull request, #14354: URL: https://github.com/apache/nuttx/pull/14354
## Summary the `link_library` of the static target will cause PRIVATE to be inherited to nuttx, resulting in duplicate linking and definition problems. because all target static libraries will eventually be linked, there is no need to specify it explicitly. ```shell # if app2 target call target_link_library(app1) # casue dup link be like ld --start-group libapp1.a libapp2.a libarch.a libboard.a --end-group libapp1.a ``` If the static definition exceeds the linker group, there is a risk of multiple definition errors. ## Impact should be compatible with all cmake build configurations ## Testing cmake -B build -DBOARD_CONFIG=qemu-armv7a:nsh CI build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
