nuttxpr commented on PR #14345:
URL: https://github.com/apache/nuttx/pull/14345#issuecomment-2415591999

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   This PR summary does not meet the NuttX requirements. 
   
   **Here's what's missing:**
   
   * **Summary:** 
       * **Insufficient detail:** "to fix ci error about 
https://github.com/apache/nuttx/pull/14293"; is too vague.  Explain the actual 
error the PR addresses, not just its origin.
       * **Missing elements:** 
           * What functional part of the code (mpfs/opnsbi) is changed, and 
*how*? 
           * How *exactly* does this change fix the CI error?
   
   * **Impact:** 
       * All sections are marked as "mpfs/opnsbi" which doesn't describe 
impact, only the area affected.  
       * Each "Impact" section needs a YES/NO answer, and a description *if* 
YES.  For example:
           * **Impact on build:**  NO 
           * **Impact on user:** YES (Users utilizing mpfs/opnsbi functionality 
may see [describe specific behavioral changes]) 
   
   * **Testing:**
       * **Insufficient detail:** Simply stating "ci" is not enough.
       * **Missing elements:**
           * List the *specific* build hosts and targets you tested on (OS, 
architecture, board, configuration).
           * Provide *actual* testing logs (before and after the change) 
demonstrating the error and its resolution.
   
   **Recommendation:**
   
   Expand your PR description substantially to meet the NuttX requirements.  
Provide clear, detailed information for each section to help reviewers 
understand and evaluate your changes. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to