nuttxpr commented on PR #14347: URL: https://github.com/apache/nuttx/pull/14347#issuecomment-2415605371
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** Here's why and how to improve it: **Missing Information:** * **Insufficient Summary:** The summary is too brief. You need to explain: * **Why is closing the block device during coredump necessary?** What problem does it solve? * **What is the "memory region bug"?** Be specific about where it occurs and how it manifests. * **How do your changes fix these issues?** Provide a technical, yet concise, explanation. * **Incomplete Impact Assessment:** * **New Feature or Bug Fix?** Clearly state if this is a new feature or a bug fix. * **User Impact:** Be more explicit. Will users experience any changes in behavior? * **Build Impact:** Do any build flags, configurations, or dependencies change? * **Hardware Impact:** Are specific architectures, boards, or drivers affected? * **Documentation:** Will documentation need to be updated to reflect these changes? * **Security/Compatibility:** Even if there's no impact, explicitly state "NO" for clarity. * **Insufficient Testing Details:** * **Build Hosts:** List the specific operating systems, CPUs, and compiler versions used for testing. * **Target Details:** Provide the architecture(s) (e.g., sim, RISC-V, ARM) and board:config combinations you tested on. * **Meaningful Test Logs:** "qemu use coredump" is not descriptive enough. Include relevant log snippets that demonstrate the problem before the change and the successful outcome after the change. Highlight the key differences. **How to Improve:** 1. **Expand the Summary:** Provide a clear and detailed explanation of the problems being solved and how your code addresses them. 2. **Complete the Impact Assessment:** Address all impact points with specific details or a clear "NO" if not applicable. 3. **Provide Thorough Testing Information:** Include specific details about your testing environment and meaningful log snippets to validate your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
