nuttxpr commented on PR #14340: URL: https://github.com/apache/nuttx/pull/14340#issuecomment-2415563883
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not meet the NuttX requirements.** **Missing Information:** * **Summary:** * **What functional part of the code is being changed?** Be specific. Which files/functions are affected by replacing `sched_[un]lock` with spinlocks? * **How does the change exactly work?** Explain the rationale behind using spinlocks in these specific cases. Why are spinlocks more appropriate than `sched_[un]lock`? * **Impact:** * **"none" is rarely the answer.** Even if the user impact is minimal, there will likely be impacts on other areas. For example: * **Impact on hardware:** Does this change affect specific architectures or boards where spinlocks behave differently? * **Impact on compatibility:** Are there any compatibility concerns with older versions of NuttX or specific configurations? * **Testing:** * **Insufficient detail.** Provide: * Specific build host details (OS, CPU architecture, compiler version). * Specific target details (architecture, board, configuration). * Relevant snippets from testing logs that demonstrate the issue before the change and the improvement after the change. **Recommendations:** 1. **Elaborate on the summary.** Clearly articulate the problem, the solution, and the affected code areas. 2. **Thoroughly analyze the impact.** Consider all potential ramifications of the change, even if they seem minor. 3. **Provide detailed testing information.** Include specific details about your test setup and relevant log snippets that illustrate the problem and the solution. By addressing these points, your PR will be better aligned with NuttX requirements and more likely to be accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
