This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new c3506448c2 drivers/serial: fix cmsdk serial driver warning
c3506448c2 is described below

commit c3506448c2b06fc94a136941a53be12ece80e05c
Author: Peter Bee <bijun...@xiaomi.com>
AuthorDate: Mon Feb 5 17:06:29 2024 +0800

    drivers/serial: fix cmsdk serial driver warning
    
    serial/serial_cmsdk.c: In function 'uart_cmsdk_ioctl':
    serial/serial_cmsdk.c:544:10: warning: 'ret' may be used uninitialized in 
this function [-Wmaybe-uninitialized]
      544 |   return ret;
          |          ^~~
    
    Signed-off-by: Peter Bee <bijun...@xiaomi.com>
---
 drivers/serial/serial_cmsdk.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/serial/serial_cmsdk.c b/drivers/serial/serial_cmsdk.c
index 16f84ca937..90a30e08aa 100644
--- a/drivers/serial/serial_cmsdk.c
+++ b/drivers/serial/serial_cmsdk.c
@@ -497,8 +497,8 @@ static int uart_cmsdk_tx_interrupt(int irq, FAR void 
*context, FAR void *arg)
 static int uart_cmsdk_ioctl(struct file *filep, int cmd, unsigned long arg)
 {
   FAR struct uart_dev_s *dev = filep->f_inode->i_private;
-  FAR struct uart_cmsdk_s *priv = dev->priv;
-  int ret;
+  FAR struct uart_cmsdk_s *priv = (FAR struct uart_cmsdk_s *)dev->priv;
+  int ret = OK;
 
   switch (cmd)
     {
@@ -514,7 +514,6 @@ static int uart_cmsdk_ioctl(struct file *filep, int cmd, 
unsigned long arg)
 
         cfsetispeed(termiosp, priv->baud);
         termiosp->c_cflag = CS8;
-        break;
       }
       break;
 

Reply via email to