pkarashchenko commented on code in PR #14333:
URL: https://github.com/apache/nuttx/pull/14333#discussion_r1801706588


##########
drivers/wireless/bluetooth/bt_bridge.c:
##########
@@ -411,6 +415,45 @@ static int bt_bridge_open(FAR struct bt_driver_s *drv)
   return OK;
 }
 
+static int bt_bridge_send_reset_response(FAR struct bt_driver_s *driver)
+{
+  uint8_t reset_response[6];
+
+  reset_response[0] = BT_HCI_EVT_CMD_COMPLETE;
+  reset_response[1] = 0x04;
+  reset_response[2] = 0x01;
+  reset_response[3] = BT_HCI_OP_RESET & 0xff;
+  reset_response[4] = (BT_HCI_OP_RESET >> 8) & 0xff;
+  reset_response[5] = BT_HCI_SUCCESS;
+
+  return bt_netdev_receive(driver, BT_EVT, reset_response,
+                           sizeof(reset_response));
+}
+
+static inline bool bt_bridge_filter_command(FAR struct bt_bridge_s *bridge,

Review Comment:
   Do we really need `inline` here?



##########
drivers/wireless/bluetooth/bt_bridge.c:
##########
@@ -411,6 +415,45 @@ static int bt_bridge_open(FAR struct bt_driver_s *drv)
   return OK;
 }
 
+static int bt_bridge_send_reset_response(FAR struct bt_driver_s *driver)
+{
+  uint8_t reset_response[6];
+
+  reset_response[0] = BT_HCI_EVT_CMD_COMPLETE;
+  reset_response[1] = 0x04;
+  reset_response[2] = 0x01;
+  reset_response[3] = BT_HCI_OP_RESET & 0xff;
+  reset_response[4] = (BT_HCI_OP_RESET >> 8) & 0xff;
+  reset_response[5] = BT_HCI_SUCCESS;
+
+  return bt_netdev_receive(driver, BT_EVT, reset_response,
+                           sizeof(reset_response));
+}
+
+static inline bool bt_bridge_filter_command(FAR struct bt_bridge_s *bridge,
+                                            FAR struct bt_driver_s *driver,
+                                            uint8_t *data)

Review Comment:
   ```suggestion
                                               FAR uint8_t *data)
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to