nuttxpr commented on PR #2738: URL: https://github.com/apache/nuttx-apps/pull/2738#issuecomment-2413962595
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) **No, this PR does not fully meet the NuttX requirements.** Here's why: * **Insufficient Detail:** The Summary section needs to be more detailed. * **Why is the change necessary?** What specific problems are being solved by optimizing `ps` and implementing `top`? * **How does the change work?** Provide a more technical explanation of how the code is being optimized and how `top` is being implemented. * **Incomplete Impact Assessment:** The Impact section lacks detail. * **New Feature:** Clearly state that `top` is a new feature. * **Impact on User:** Describe how users will use the new `top` command and any changes to how they might use the `ps` command. * **Impact on Build/Hardware/Documentation/Security/Compatibility:** Address all these points, even if the answer is "NO." Provide a brief explanation. * **Missing Testing Information:** * **Build Hosts:** Specify the operating systems, architectures, and compilers used for testing. * **Targets:** Be specific about the target architectures, boards, and configurations used for testing. * **Testing Logs:** Provide actual testing logs (or snippets) showing the output of `ps` and `top` before and after the changes. **To improve this PR:** 1. **Expand the Summary section** with more details about the "why" and "how" of the changes. 2. **Provide a thorough Impact assessment**, addressing all the listed points. 3. **Complete the Testing section** with specific information about your test environment and include relevant testing logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
