nuttxpr commented on PR #14327: URL: https://github.com/apache/nuttx/pull/14327#issuecomment-2413941551
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR **does not meet** the NuttX requirements. Here's why: * **Insufficient Summary:** The summary provides a high-level overview but lacks crucial details: * **Why is this change necessary?** Clearly state the problem the PR solves. Is code coverage broken for LLVM/Clang? Is this a new feature to enable better tooling? * **How does the change work?** Be more specific than "porting the library." Explain how the library integrates, what modifications were made for NuttX, etc. * **Impact Section is Unrealistic:** It's highly unlikely a change of this nature has *no* impact. Address each point specifically: * **Build Impact:** Adding a new library and integrating it into the kernel *will* change the build process. How? * **Hardware Impact:** Which architectures are affected by the LLVM compiler runtime? * **Documentation:** Does this require documentation updates? * **Compatibility:** Will this affect applications built against older NuttX versions? * **Testing is Insufficient:** "No" is not an acceptable answer. You **must** provide: * **Build Host Details:** List the OS, CPU architecture, compiler version used for testing. * **Target Details:** Specify the architectures and boards used for validation. * **Testing Logs:** Include relevant logs demonstrating the issue *before* the change and the improvement *after* the change. **In short, the PR needs significantly more detail and evidence of testing to be considered.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
