nuttxpr commented on PR #14325: URL: https://github.com/apache/nuttx/pull/14325#issuecomment-2413857243
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This Pull Request appears **incomplete** based on the provided NuttX requirements. **Here's why and what's missing:** * **Summary:** * **Missing:** * **WHY** is this change necessary? What are the benefits of disabling floating-point compilation? (e.g., reduced code size, targeting platforms without FPU support). * **HOW** exactly does the change work? What mechanism is used to disable floating-point? (e.g., compiler flag, configuration option) * **Impact:** * **Incomplete:** * **Impact on user:** While stating "some platforms can't use float" hints at the reason, you need to be **explicit**. Will users need to change their code if they rely on floating-point operations? How will this affect existing applications? * **Impact on build:** How does this change the build process? Is there a new configuration option? * **Impact on hardware:** Be specific about which architectures/boards are affected. * **Impact on documentation:** If this introduces a new option, documentation MUST be updated. State that you've done so or that it's needed. * **Unclear/Missing:** * **Impact on security:** Are there any potential security implications of disabling floating-point? (e.g., related to numerical stability or calculations). * **Impact on compatibility:** Will this break compatibility with any existing code or libraries that rely on floating-point? * **Testing:** * **Insufficient:** * **Build Host(s):** Provide details about your build host operating system, CPU architecture, and compiler version. * **Target(s):** "qemu with mps3an547" is not enough. Specify the QEMU version, the exact MPS3 board configuration being emulated, and any relevant details about the simulated environment. * **Testing logs:** You need to provide **actual** testing logs (both before and after the change). These logs should demonstrate that the change works as intended and doesn't introduce regressions. **To improve this PR:** 1. **Expand on the Summary:** Clearly articulate the motivation, benefits, and technical implementation of the change. 2. **Complete the Impact assessment:** Address all points, being specific and detailed about the consequences of this change. 3. **Provide comprehensive Testing information:** Include specific details about your build and target environments, and most importantly, **include actual testing logs** that validate your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
